Skip to content
This repository has been archived by the owner on Jan 4, 2018. It is now read-only.

[+] updated to react 0.14.0 #35

Merged
merged 1 commit into from
Oct 15, 2015

Conversation

eyala-stratoscale
Copy link
Contributor

No description provided.

@emmenko
Copy link
Owner

emmenko commented Oct 14, 2015

Thanks!

One thing to adjust regarding the owner context

@eyala-stratoscale
Copy link
Contributor Author

I'm looking through v0.14 docs, couldn't find anything regarding it.
What should this line be instead of : {renderRoutes.bind(null, props.history)} ?

@emmenko
Copy link
Owner

emmenko commented Oct 15, 2015

Just renderRoutes(props.history) :)

@eyala-stratoscale
Copy link
Contributor Author

Updated, have a look

@emmenko
Copy link
Owner

emmenko commented Oct 15, 2015

👍

Can you confirm that everything works fine? Then I can merge :)

@eyala-stratoscale
Copy link
Contributor Author

Hey,
When I checked it yesterday it seemed ok, but I'm quite new to this and
don't know your code.
It's better that you have a look when you have time.

On Thu, Oct 15, 2015 at 3:37 PM, Nicola Molinari notifications@github.com
wrote:

[image: 👍]

Can you confirm that everything works fine? Then I can merge :)


Reply to this email directly or view it on GitHub
#35 (comment)
.

import { Link } from 'react-router'

export default class MenuListItem {
export default class MenuListItem extends Component{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before the bracket Component {

@emmenko
Copy link
Owner

emmenko commented Oct 15, 2015

Fix the lint, then it's good to merge (just tested it locally).

@eyala-stratoscale
Copy link
Contributor Author

fixed

On Thu, Oct 15, 2015 at 3:45 PM, Nicola Molinari notifications@github.com
wrote:

Fix the lint, then it's good to merge (just tested it locally).


Reply to this email directly or view it on GitHub
#35 (comment)
.

@emmenko
Copy link
Owner

emmenko commented Oct 15, 2015

👍 thanks for the PR!

emmenko added a commit that referenced this pull request Oct 15, 2015
@emmenko emmenko merged commit b2fe4a1 into emmenko:master Oct 15, 2015
@eyala-stratoscale
Copy link
Contributor Author

you welcome, thanks for the repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants