Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove-modules-dependency: Remove unnecessary modules listing #34

Merged
merged 17 commits into from
Mar 19, 2023
Merged

remove-modules-dependency: Remove unnecessary modules listing #34

merged 17 commits into from
Mar 19, 2023

Conversation

emmeowzing
Copy link
Owner

@emmeowzing emmeowzing commented Mar 17, 2023 •
edited
Loading

what

why

  • Users should have the ability to auto-detect modules instead of manually listing them in their .circleci/config.yml.

references

@emmeowzing emmeowzing added the feature New functionality. label Mar 17, 2023
@emmeowzing emmeowzing self-assigned this Mar 17, 2023
@emmeowzing emmeowzing linked an issue Mar 17, 2023 that may be closed by this pull request
Are modules even necessary to list when we have targeted configs? #23
Closed
@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:aab8d8a6ad60c150d2091e14d65ab546c3b3c26a

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:4a0ec8f90abd4092ff934e4194b412e673f4bfb5

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:963e6d5f09718a58eeae94544d2b6bc392c905eb

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:1d5dfc26c7d3daeb4a91add88addfcd451736e8d

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:b2448ce5fa7904f96744b26e87598b84130e7d90

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:39232c78e690f11bd60836930e31a69d69e3e0f4

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:def4c4ea23450252b94a685d67ac902b70047996

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:090adb33a0a22137d8e9d495956d67300e5b8f1c

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:8a907c6d1484837605dbc3c73d3a9575a41d32ae

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:eebc34db8fe216e3eee16a5848cbfc8fa790b8e4

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:9c36f9966e0220985fd01b79871304b969a4f5ee

@emmeowzing
Copy link
Owner Author

Reverted debugging commits, auto-detecting modules appears to be working just fine, now.

@emmeowzing
Copy link
Owner Author

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:47538b41d1d69cacda9d0dd714d7800eb8c752c3

@emmeowzing emmeowzing merged commit 1a70279 into master Mar 19, 2023
@emmeowzing emmeowzing deleted the remove-modules-dependency branch March 19, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emmeowzing emmeowzing

Labels
feature New functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Are modules even necessary to list when we have targeted configs?
1 participant
@emmeowzing