Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change grep to filter out root circleci config only #84

Merged

Conversation

dtomlinson91
Copy link
Contributor

@dtomlinson91 dtomlinson91 commented Jul 2, 2023

Me again 馃珷

Proposed (small) change to allow directories that have config somewhere in their path.

Our use case is great expectations. This uses a directory config to store all the expectation suites/connection details etc. We build Docker images when files in this config directory are changed, but currently the orb excludes all directories that have config in the name when using auto-detection.

If I understand correctly the filter stage wants to get a list of all the modules in .circleci, but exclude the root config.yml that CircleCI uses.

Currently:
image

With proposed change (containing /airflow.custom_containers.great_expectations.config.docs):
image

what

  • The filter step currently runs grep -v config to filter out the root circleci config.yml.
  • This means any modules with config in their directory paths are excluded when auto-detect is true.

why

  • Changing the grep filter to "^/config$" will allow modules that have a directory containing config in their path while excluding the root circleci file.

references

n/a

@emmeowzing emmeowzing added the feature New functionality. label Jul 2, 2023
@emmeowzing emmeowzing merged commit ad8836d into emmeowzing:master Jul 2, 2023
1 check failed
@emmeowzing emmeowzing mentioned this pull request Jul 2, 2023
@emmeowzing
Copy link
Owner

emmeowzing commented Jul 2, 2023

Should be fixed in v3.6.12 @dtomlinson91

@dtomlinson91
Copy link
Contributor Author

@bjd2385 Legend thank you so much 馃榿 I have 30 Docker images now conditionally building in GCP with your orb, will save us ~拢500 a month in build time.

@emmeowzing
Copy link
Owner

@dtomlinson91 that's great to hear! Let me know if you have any other ideas as far as improvements or ways we can save even more ha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants