fix: change grep to filter out root circleci config only #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me again 馃珷
Proposed (small) change to allow directories that have
config
somewhere in their path.Our use case is great expectations. This uses a directory
config
to store all the expectation suites/connection details etc. We build Docker images when files in this config directory are changed, but currently the orb excludes all directories that haveconfig
in the name when using auto-detection.If I understand correctly the filter stage wants to get a list of all the modules in
.circleci
, but exclude the rootconfig.yml
that CircleCI uses.Currently:
![image](https://private-user-images.githubusercontent.com/53234158/250368296-5d19b5f8-19da-4d1e-99d0-bfa3dd2ee836.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1MzY5ODUsIm5iZiI6MTcxOTUzNjY4NSwicGF0aCI6Ii81MzIzNDE1OC8yNTAzNjgyOTYtNWQxOWI1ZjgtMTlkYS00ZDFlLTk5ZDAtYmZhM2RkMmVlODM2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAxMDQ0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIxNTM5M2I5MDVhYWY0YTg2OWY4ZjllN2E3OTYyYjI4ODM3Y2Q3MTI3NjE4MDFjZDY1ODQxYjJjODA5MWZiOWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UG3MykxXd_zuzU7ZVpgR7dQBjNLAg2hld3N2ihf5K4M)
With proposed change (containing
![image](https://private-user-images.githubusercontent.com/53234158/250368327-50e0826d-2c0c-4965-8be1-377f83245ed1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1MzY5ODUsIm5iZiI6MTcxOTUzNjY4NSwicGF0aCI6Ii81MzIzNDE1OC8yNTAzNjgzMjctNTBlMDgyNmQtMmMwYy00OTY1LThiZTEtMzc3ZjgzMjQ1ZWQxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAxMDQ0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3Yjk3YWExYjEwZjhmNmI0ZWM2YjkzNDM5MGM3MGZhZjZiYTQ5ZWFhZTU4MjI4Zjk5MmQ3ZTJmOTQ4NWY3OTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PUTKejRG6kgSo4BEgJQ9kXUJVteBIQh9Qxal_s4ndkk)
/airflow.custom_containers.great_expectations.config.docs
):what
grep -v config
to filter out the root circleci config.yml.config
in their directory paths are excluded when auto-detect istrue
.why
"^/config$"
will allow modules that have a directory containingconfig
in their path while excluding the root circleci file.references
n/a