fix: modules filtered formatting when force-all is enabled #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphapr
changed the title
raphapr
added a commit
to raphapr/dynamic-continuation-orb
that referenced
this pull request
Sep 8, 2023
fix: modules filtered formatting when force-all is enabled emmeowzing#93
Closed
|
Thank you for your contribution @raphapr , I will look into this |
|
@raphapr this fix has been published in v3.7.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
fix force-all feature, which is currently broken; the filter script is not properly formatting the filtered modules file in filter script.
why
basically, add newline character to the printf responsible for generating the filtered modules file before the reduce script
references
N/A