--prefer-revision-newer argument don't seems to work

[zognic]

Paste the command

npx igir@latest move zip test clean report \ --dat "./No-Intro*.zip" \ --input "./No-Intro/" \ --output "./No-Intro/" \ --no-bios \ --no-bad \ --single \ --no-beta \ --no-demo \ --no-prototype \ --no-test-roms \ --prefer-language FR \ --prefer-region USA,WORLD,EUR,JPN \ --prefer-revision-newer \ --prefer-retail \ --language-filter FR,EN \ --filter-regex-exclude "/(InfoGenius)/i" \ --dir-dat-name

Describe the bug

The script moved all the versions of the rom

Warp Coin Catastrophe, The (World) (v1.0) (Aftermarket) (Unl).zip
Warp Coin Catastrophe, The (World) (v1.1) (Aftermarket) (Unl).zip
Warp Coin Catastrophe, The (World) (v1.1.2) (Aftermarket) (Unl).zip

Expected behavior

With --prefer-revision-newer argument I expected that the script will keep only the last revision of the file, i-e:

Warp Coin Catastrophe, The (World) (v1.1.2) (Aftermarket) (Unl).zip

Debug logs

N/A

igir version

@latest

Node.js version

v20.1.0

Operating system

Apple M1 - 13.4

Additional context

No response

[emmercm]

It looks like No-Intro's DAT doesn't have parent information for that ROM, none of the games have a cloneof property:

<!-- Nintendo - Game Boy (Parent-Clone) (20230429-103223).dat -->
<game name="Warp Coin Catastrophe, The (World) (v1.1) (Aftermarket) (Unl)">
    <description>Warp Coin Catastrophe, The (World) (v1.1) (Aftermarket) (Unl)</description>
    <rom name="Warp Coin Catastrophe, The (World) (v1.1) (Aftermarket) (Unl).gb" size="1048576" crc="a381c914" md5="2295f4ef94f9b9a21dfc04259ab6d7bf" sha1="adf37c5d2f706743b2a4946378df49ed19212039"/>
</game>
<game name="Warp Coin Catastrophe, The (World) (v1.0) (Aftermarket) (Unl)">
    <description>Warp Coin Catastrophe, The (World) (v1.0) (Aftermarket) (Unl)</description>
    <rom name="Warp Coin Catastrophe, The (World) (v1.0) (Aftermarket) (Unl).gb" size="1048576" crc="1bfe1bf9" md5="c1ef769ab7525ca2b2c3b0eb88b1c49c" sha1="fae12dbbb75ae024e96a7ee21ad4077fdb5ed9a1"/>
</game>
<game name="Warp Coin Catastrophe, The (World) (v1.1.2) (Aftermarket) (Unl)">
    <description>Warp Coin Catastrophe, The (World) (v1.1.2) (Aftermarket) (Unl)</description>
    <rom name="Warp Coin Catastrophe, The (World) (v1.1.2) (Aftermarket) (Unl).gb" size="1048576" crc="5519c167" md5="d5aef2fb975eebf3b66ea89c469d0d7c" sha1="04a53af6a77b884af91f8047d70fc0331bf23913"/>
</game>

I'm not sure what No-Intro's process is for suggested community changes, but this should probably follow that.

igir is exclusively using cloneof properties in DATs for 1G1R, it doesn't do any additional inference. It's something that's been on my mind because other groups such as Redump don't include parent information in their DATs.

[zognic]

I see, thanks a lot for your really quick answer

[emmercm]

Converted to a feature request, as this is currently expected and not a bug: #431

[github-actions]

🔒 Inactive issue lock

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.