-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily return to rapidjson #292
Comments
I modified: and [2] output = 'str' (with orjosn output = 'bytes') and in a simple example it works [1] emmett/serializers.py |
@josejachuf yes it should be enough. I'm thinking about a patch-release to make orjson an extra, will update you if I decide in that direction |
Hi @gi0baro. This how it would be, a parameter would be passed to App () when instantiating the application to tell it to use orjson? |
@josejachuf I was thinking more to extra-packages, eg: |
Ok. And then use try...except imports? |
@josejachuf yep, I can't think about a better approach. btw, I still need to think about this, AFAIK on the main platforms the only issue right now with |
Hi @gi0baro,
is the library used (orjson / rapidjson) that defines the data type? |
@josejachuf yes, |
@josejachuf with v2.1.1 I'm closing this. |
Thanks @gi0baro |
I received help to install maturin in freebsd and already with maturin installed orjson it installed without problems. in this link [1] is the solution in case someone needs it.
Here's the trick:
Then in your virtualenv simply:
[1] PyO3/maturin#363 |
I have a problem that is not directly from emmett but with the installation of orjson.
All the server infrastructure I use is freebsd (+ jails). The orjson installation with pip does not use binaries, it is compiled. To compile you need to install some dependencies, including maturin. In the maturin installation an error occurs (I reported it) and therefore I cannot install orjson.
I've been seeing this [1]
What I want to do is temporarily modify serializers.py [2] and go back to rapidjson. This is apparently the only place where orjson is referenced. The query is if this change is enough and nothing will break.
[1] 2878fbd
[2] 5bbbae3
The text was updated successfully, but these errors were encountered: