Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRIs uniformation #262

Closed
wants to merge 7 commits into from
Closed

IRIs uniformation #262

wants to merge 7 commits into from

Conversation

hothello
Copy link
Collaborator

@hothello hothello commented Feb 8, 2024

  • Added the script fixes.sh to automatically find and replace IRIs in non-standard formats:
    • :hex_hex_hex_hex_hex to :EMMO_hex_hex_hex_hex_hex
    • :EMMO_hex-hex-hex-hex-hex to :EMMO_hex_hex_hex_hex_hex
    • <http://emmo.info/emmo#hex_hex_hex_hex_hex> to :EMMO_hex_hex_hex_hex_hex
  • Fixed typos in author's names, affiliations, countries, and formatted all entries in the same way.
  • Changed triples double-quotes (""") to single ones (").
  • Typo removed from the elucidation of hasSpatialTile.

* :hex_hex_hex_hex_hex to :EMMO_hex_hex_hex_hex_hex
* :EMMO_hex-hex-hex-hex-hex to :EMMO_hex_hex_hex_hex_hex
* <http://emmo.info/emmo#hex_hex_hex_hex_hex> to :EMMO_hex_hex_hex_hex_hex

Also, fixed typos in author's names, affiliations, countries, and formatted all entries in the same way.
Changed triples double-quotes (""") to single ones (").
Typo removed from the elucidation of hasSpatialTile.
@hothello hothello closed this Feb 8, 2024
@hothello hothello reopened this Feb 8, 2024
@hothello hothello mentioned this pull request Feb 8, 2024
@hothello
Copy link
Collaborator Author

hothello commented Feb 9, 2024

A working note. As a lot of IRIs have changed, merging future branches could be time-consuming. I suggest applying the same rules before committing an merging future branches with the (updated) ./scripts/fixes.sh:

for i in $(find . -name "*ttl");
do
  # Convert the IRI with the format EMMO_hex-hex-hex-hex-hex.
  sed -i -E 's/EMMO_([0-9a-f]+)-([0-9a-f]+)-([0-9a-f]+)-([0-9a-f]+)-([0-9a-f]+)/EMMO_\1_\2_\3_\4_\5/g' "$i";
  # Convert the IRI without the EMMO_ prefix.
  sed -i -E 's/:([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)/:EMMO_\1_\2_\3_\4_\5/g' "$i";
  # Convert the IRI with the format <http://emmo.info/emmo#hex_hex_hex_hex_hex>.
  sed -i -E 's/<http:\/\/emmo.info\/emmo#([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)_([0-9a-f]+)>/:EMMO_\1_\2_\3_\4_\5/g' "$i";
done

@@ -37,7 +37,7 @@ We kindly acknowledge NIST for reusing their content, including the selection of
### http://emmo.info/emmo#AmperePerJoule
emmo:AmperePerJoule rdf:type owl:Class ;
rdfs:subClassOf emmo:EMMO_1273eb34_de48_43a9_925f_104110469dd2 ,
emmo:EMMO_1aaaceb6-c5eb-4cf3-a494-f82d43fda10a ,
emmo:EMMO_1aaaceb6_c5eb_4cf3_a494_f82d43fda10a ,
Copy link
Contributor

@jesper-friis jesper-friis Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spottet!
This one is most likely on me. Seems that the uuid module in Python uses hyphens instead of underscore.

@jesper-friis
Copy link
Contributor

Good work Otello. I think that we should make a new release before merging this PR, since it changes a lot of IRIs.

It should probably also be time-wise close to the change to w3id's, such that domain ontologies can handle the IRI-changes in one go.

@hothello
Copy link
Collaborator Author

hothello commented Feb 9, 2024

Good work Otello. I think that we should make a new release before merging this PR, since it changes a lot of IRIs.

It should probably also be time-wise close to the change to w3id's, such that domain ontologies can handle the IRI-changes in one go.

The fixes on the IRIs are automatic. We could ditch this branch entirely and only save the bash script, plus the corrections to the Ontology annotations (misspelled name, wrong/old affiliations, different formats), which is a trivial merge.

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Otello. The changes are fine.

I approve, but I wonder whether it would be smart to make a release and apply these changes to 1.0.0-beta6 to not make trouble for people already using 1.0.0-beta5.

@hothello
Copy link
Collaborator Author

I approve, but I wonder whether it would be smart to make a release and apply these changes to 1.0.0-beta6 to not make trouble for people already using 1.0.0-beta5.

It's a good idea to change the IRIs directly in the next beta release. Allow me to revert to the previous IRIs but keeping the corrections to the elucidations, then we can merge what remains to the beta5.

@jesper-friis
Copy link
Contributor

I approve, but I wonder whether it would be smart to make a release and apply these changes to 1.0.0-beta6 to not make trouble for people already using 1.0.0-beta5.

It's a good idea to change the IRIs directly in the next beta release. Allow me to revert to the previous IRIs but keeping the corrections to the elucidations, then we can merge what remains to the beta5.

I don't think you need to do any changes. It is very easy to apply your PR to beta6 when we have released beta5.

@jesper-friis
Copy link
Contributor

Please note: this branch is merged in to 1.0.0-beta6.

The PR is only kept here for reference.

@jesper-friis
Copy link
Contributor

Closing - already merged into 1.0.0-beta7 and 1.0.0-final-dev-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants