Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #119

Merged
merged 9 commits into from
Jan 20, 2021
Merged

Update CI #119

merged 9 commits into from
Jan 20, 2021

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Jan 19, 2021

Summary of what has changed in this PR concerning CI:

  • Use PyPI token for publishing (closes Use PyPI token in publish workflow #118).
  • Add a CI test to build and install the Python package to ensure any new changes doesn't disrupt building the package.
    This is done for both the source distribution (sdist) and for the built distribution (bdist_wheel) using ubuntu-latest.
  • Run CI for all PRs and only for pushes to master.
  • Split up CI job build to individual jobs to have a better overview.
  • Provide the flake8 linting with some teeth, in the form of not turning all errors into warnings.

Code fixes:

  • Based on the flake8 linting, the files have been updated accordingly.
  • Add requirements.txt to the MANIFEST.in as the "build and install Python package"-test failed due to missing the requirements.txt file.
    You might never have experienced this, if you didn't install from PyPI.

@CasperWA CasperWA changed the title Use PyPI token for publishing - test building package Update CI Jan 19, 2021
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Thank you!

We may consider to enforce even more flake8 linting

@CasperWA
Copy link
Contributor Author

I'm not authorized to merge, so feel free to merge anytime :)

@CasperWA
Copy link
Contributor Author

We may consider to enforce even more flake8 linting

Right. For this, I would consider using pre-commit to run a flake8 check on every local commit made. One might consider using the Black formatter as well?

@jesper-friis jesper-friis merged commit 59346d1 into emmo-repo:master Jan 20, 2021
@CasperWA CasperWA deleted the fix_118_use-pypi-token branch January 20, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use PyPI token in publish workflow
2 participants