Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reading xml as 'rdfxml' #139

Merged
merged 6 commits into from
Mar 16, 2021
Merged

Conversation

francescalb
Copy link
Collaborator

Note that owlxml is not supported now...

@francescalb francescalb changed the title WIP: Fixed reading xml as 'rdfxml' Fixed reading xml as 'rdfxml' Mar 15, 2021
@francescalb
Copy link
Collaborator Author

Note that owlxml is not supported now...

I think it all works now, so please review

@francescalb francescalb linked an issue Mar 15, 2021 that may be closed by this pull request
emmo/ontology.py Outdated
@@ -69,7 +69,7 @@ def get_ontology(self, base_iri='emmo-inferred'):
of EMMO
"""
if base_iri == 'emmo':
base_iri = 'http://emmo.info/emmo'
base_iri = 'https://emmo-repo.github.io/latest-stable/emmo.owl'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By loading EMMO as a single file we will loose the possibility to easily list the individual ontologies separately as well as the documentation of the individual ontologies. On the positive side, it will load much faster. It is up to us to decide. Probably this is a good choice.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think importing separate files is the most correct for this. Otherwise the inferred version can be uploaded. I changed the uri to the raw as http://emmo.info/emmo did not work

emmo/ontology.py Outdated
@@ -69,7 +69,7 @@ def get_ontology(self, base_iri='emmo-inferred'):
of EMMO
"""
if base_iri == 'emmo':
base_iri = 'http://emmo.info/emmo'
base_iri = 'https://emmo-repo.github.io/latest-stable/emmo.owl'
elif base_iri == 'emmo-inferred':
base_iri = (
'https://emmo-repo.github.io/latest-stable/emmo-inferred.ttl')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to load the owl file instead of ttl to save temporary conversion and storage of the ontology.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done. Have to change this if emmo eventually stops supporting owl

Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest that "emmo-inferred" should load the owl file instead of ttl

@francescalb francescalb merged commit ace0bb8 into master Mar 16, 2021
@francescalb francescalb deleted the issue138_Update_convertimported branch March 16, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert-imported update in utils
2 participants