-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed reading xml as 'rdfxml' #139
Conversation
I think it all works now, so please review |
emmo/ontology.py
Outdated
@@ -69,7 +69,7 @@ def get_ontology(self, base_iri='emmo-inferred'): | |||
of EMMO | |||
""" | |||
if base_iri == 'emmo': | |||
base_iri = 'http://emmo.info/emmo' | |||
base_iri = 'https://emmo-repo.github.io/latest-stable/emmo.owl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By loading EMMO as a single file we will loose the possibility to easily list the individual ontologies separately as well as the documentation of the individual ontologies. On the positive side, it will load much faster. It is up to us to decide. Probably this is a good choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think importing separate files is the most correct for this. Otherwise the inferred version can be uploaded. I changed the uri to the raw as http://emmo.info/emmo did not work
emmo/ontology.py
Outdated
@@ -69,7 +69,7 @@ def get_ontology(self, base_iri='emmo-inferred'): | |||
of EMMO | |||
""" | |||
if base_iri == 'emmo': | |||
base_iri = 'http://emmo.info/emmo' | |||
base_iri = 'https://emmo-repo.github.io/latest-stable/emmo.owl' | |||
elif base_iri == 'emmo-inferred': | |||
base_iri = ( | |||
'https://emmo-repo.github.io/latest-stable/emmo-inferred.ttl') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea to load the owl file instead of ttl to save temporary conversion and storage of the ontology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done. Have to change this if emmo eventually stops supporting owl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest that "emmo-inferred" should load the owl file instead of ttl
Note that owlxml is not supported now...