Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option url_from_catalog to ontology.load() #58

Merged
merged 6 commits into from
Oct 29, 2020
Merged

Added option url_from_catalog to ontology.load() #58

merged 6 commits into from
Oct 29, 2020

Conversation

jesper-friis
Copy link
Collaborator

Seems to work. Great if you can test it.

@francescalb
Copy link
Collaborator

works fine for me, I added the option to emmocheck. Please check.

@jesper-friis
Copy link
Collaborator Author

works fine for me, I added the option to emmocheck. Please check.

Works fine with emmocheck too.

francescalb
francescalb approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been checked by us both and works well. Ready to merge

@francescalb francescalb merged commit 87cf467 into master Oct 29, 2020
@jesper-friis jesper-friis deleted the url-from-catalog branch October 31, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesper-friis @francescalb