Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the '.ttl' in namespace names by monkey patching owlready2.Namespace #90

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Remove the '.ttl' in namespace names by monkey patching owlready2.Namespace #90

merged 1 commit into from
Jan 4, 2021

Conversation

jesper-friis
Copy link
Collaborator

No description provided.

@jesper-friis jesper-friis linked an issue Dec 29, 2020 that may be closed by this pull request
Remove the .ttl namespace when loading domain-crystallography in EMMO-python #83
Closed
@jesper-friis jesper-friis added this to In progress in EMMO-python 1.0.0 via automation Dec 29, 2020
francescalb
francescalb reviewed Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot check this until import of emmo-inferred has been fixed (Issue 98)

francescalb
francescalb approved these changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing crystallography has been fixed. Approved.

@francescalb francescalb merged commit 895f4f1 into master Jan 4, 2021
EMMO-python 1.0.0 automation moved this from In progress to Done Jan 4, 2021
@jesper-friis jesper-friis deleted the remove_ttl_namespace branch January 4, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
EMMO-python 1.0.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the .ttl namespace when loading domain-crystallography in EMMO-python
2 participants
@jesper-friis @francescalb