Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BXMSDOC-4148 Installing and configuring DM 7.4 and PAM 7.4 on EAP, JWS, and Tomcat #173

Merged
merged 11 commits into from Jul 8, 2019

Conversation

emmurphy1
Copy link
Owner

Continuation of this pull request. Previous changed content merge for clearer reviews.

Includes:
BXMSDOC-4013 Installing and configuring DM 7.4 and PAM 7.4 on EAP (epic)
BXMSDOC-4013 Database specific troubleshooting tips missing from the RHPAM 7 documentation
BXMSDOC-4013 Installation Guides are missing section for DB setup

BXMSDOC-4015 Installing PAM/DM 7.4 on JWS

BXMSDOC-4148 Installing and configuring DM/PAM 7.4 on Tomcat 9 Server.

Note that this merge request includes stories for three platforms because of shared files, to ensure changes do not break any of the stories.

See jiras for details.

@@ -46,7 +46,7 @@ Specify the home directory of the following servers: Red Hat JBoss EAP 7.1 or R
[/home/user/{PRODUCT_INIT_CAP}-{PRODUCT_VERSION_LONG}/jboss-eap-7.1]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated eap version in example

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is obsolete. Removed from repo.

@emmurphy1 emmurphy1 merged commit 91cf91e into BXMSDOC-4148-master-final Jul 8, 2019
emmurphy1 added a commit that referenced this pull request Jul 8, 2019
BXMSDOC-4148 Installing and configuring DM 7.4 and PAM 7.4 on EAP, JWS, and Tomcat
@@ -14,7 +14,7 @@ This document describes how to install {PRODUCT} {PRODUCT_VERSION} on JBoss Web

.Prerequisites
* You have reviewed the information in {URL_PLANNING_INSTALL}[_{PLANNING_INSTALL}_].
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fond of this sentence structure. Why do we not use imperative?
Prerequisites:
Review the ....
Install the.....

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a team, we adapted this format for prerequisites. We intentionally use the passive voice here. Because prerequisites are things that you should have done, they need to be in the past tense. We list it in our peer review guide.

One reason not to use the imperative in prereqs is that they would look an awful lot like the actual procedure.

.Procedure
. In the `settings.xml` file, declare the repositories that your {PRODUCT} projects use. Usually, this is either the https://maven.repository.redhat.com/ga/[online {PRODUCT} Maven repository] or the
{PRODUCT} Maven repository that you download from the Red Hat Customer Portal and any repositories for custom artifacts that you want to use.
. Ensure that {CENTRAL} or {KIE_SERVER} is configured to use the `settings.xml` file , for example by specifying the `kie.maven.settings.custom=<SETTINGS_FILE_PATH>` property where `<SETTINGS_FILE_PATH>` is the path to the `settings.xml` file.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we simply not say "for example, specify kie.maven....."?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i like that. Changing.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been updated to "for example, specify kie.maven..."?

====
Ensure the names of the {PRODUCT} deployments you are copying do not conflict with your existing deployments in the
Ensure the names of the {PRODUCT} deployments you are copying do not conflict with your existing deployments in the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...you copy..." Why present continuous tense?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Changing.

----
endif::DM[]
+
In the preceding examples, replace the following variables:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another example after this that is part of a sequence? If not should we just say "previous" instead of "preceding"?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I confess I have a personal bias for that form for no good reason then consistency and habit. I asked Stetson about this and here is his take:
"Preceding is "correct" when it immediately follows. Previous is "correct" if it's farther away. So in the example you're giving, if I had to choose between the two, I would go with preceding. But I just don't use it at all anyway in such cases. Not an issue of correctness as much as superfluity."

So I guess I was correct but I take his point about superfluity.

@@ -5,7 +5,7 @@ Test scenarios in {PRODUCT} enable you to validate the functionality of business

{PRODUCT} currently supports both the new *Test Scenarios* designer and the former *Test Scenarios (Legacy)* designer. The default designer is the new test scenarios designer, which supports testing of both rules and DMN models and provides an enhanced overall user experience with test scenarios. If required, you can continue to use the legacy test scenarios designer, which supports rule-based test scenarios only.

You can run the defined test scenarios in a number of ways, for example, you can run available test scenarios at the project level or inside a specific test scenario asset. Test scenarios are independent and cannot affect or modify other test scenarios. You can run test scenarios at any time during project development in {CENTRAL}. You do not have to compile or deploy your decision service to run test scenarios. For more information about running test scenarios, see xref:test-designer-run-test-proc[].
You can run the defined test scenarios in a number of ways, for example, you can run available test scenarios at the project level or inside a specific test scenario asset. Test scenarios are independent and cannot affect or modify other test scenarios. You can run test scenarios at any time during project development in {CENTRAL}. You do not have to compile or deploy your decision service to run test scenarios.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... run defined test scenarios..." or "... run the defined test..."

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. That's not my text :-) Stetson asked me to delete the highlighted xref as a favor when I merged this PR. There are a few issues there. I'll look at it.


.Procedure
. In the `settings.xml` file, declare the repositories that your {PRODUCT} projects use. Usually, this is either the https://maven.repository.redhat.com/ga/[online {PRODUCT} Maven repository] or the
{PRODUCT} Maven repository that you download from the Red Hat Customer Portal and any repositories for custom artifacts that you want to use.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should maven be initial capped here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. On the Apache Maven site, they treat Maven as a proper noun, which I think it is anyway. Did you have an argument for not capping?

ifeval::["{context}" == "install-on-jws"]
`_JWS_HOME_/tomcat/bin`
endif::[]
ifeval::["{context}" == "install-on-tomcat"]
`_TOMCAT_HOME_/tomcat/bin`
endif::[]
directory of the instance running the {HEADLESS_CONTROLLER}, create a readable `setenv.sh` file with the following content:
directory of the instance running the {HEADLESS_CONTROLLER}, create a readable `setenv.sh` file with the following content where `<USERNAME>` is {KIE_SERVER} user and `<USER_PWD>` is the password for that user:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comma after "... following content, ..."

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -136,6 +149,11 @@ The pooling data source configuration relies on additional resource that have be
. Configure {KIE_SERVER} to use the data source:
.. Open one of the following scripts in a text editor:
+
[NOTE]
====
The `setenv.sh` or `setenv.bat` script should already exist. However, if it does not, create it.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why (what circumstances) would it not exist?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent question. I'll ask an SME.

Copy link

@csherrar csherrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and questions, otherwise looks good to me.

ifdef::PAM[]
and then configure the Java Database Connectivity (JDBC) web server data sources on {TOMCAT}
and then configure the Java Database Connectivity (JDBC) web server data sources on {TOMCAT}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing full stop after {TOMCAT}.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, @csherrar the full stop isn't missing. It just looks that way because of the use of conditions. Always check the rendered doc.

.Procedure
. In the `settings.xml` file, declare the repositories that your {PRODUCT} projects use. Usually, this is either the https://maven.repository.redhat.com/ga/[online {PRODUCT} Maven repository] or the
{PRODUCT} Maven repository that you download from the Red Hat Customer Portal and any repositories for custom artifacts that you want to use.
. Ensure that {CENTRAL} or {KIE_SERVER} is configured to use the `settings.xml` file , for example by specifying the `kie.maven.settings.custom=<SETTINGS_FILE_PATH>` property where `<SETTINGS_FILE_PATH>` is the path to the `settings.xml` file.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been updated to "for example, specify kie.maven..."?

. Ensure that {CENTRAL} or {KIE_SERVER} is configured to use the `settings.xml` file , for example by specifying the `kie.maven.settings.custom=<SETTINGS_FILE_PATH>` property where `<SETTINGS_FILE_PATH>` is the path to the `settings.xml` file.
+
ifeval::["{context}" == "install-on-jws"]
On {JWS}, for {KIE_SERVER} add `-Dkie.maven.settings.custom=<SETTINGS_FILE_PATH>` to the `CATALINA_OPTS` section of the `setenv.sh` (Linux) or `setenv.bat` (Windows) file. .For standalone {CENTRAL}, enter the following command:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The below sentence needs to be moved to new line or the full stop removed from the start:

".For standalone {CENTRAL}, enter the following command:"

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated to For example...
full stop.. thanks. Good catch.

----
endif::[]
ifeval::["{context}" == "install-on-tomcat"]
On {TOMCAT}, for {KIE_SERVER} add `-Dkie.maven.settings.custom=<SETTINGS_FILE_PATH>` to the `CATALINA_OPTS` section of the `setenv.sh` (Linux) or `setenv.bat` (Windows) file. .For standalone {CENTRAL}, enter the following command:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The below sentence needs to be moved to new line or the full stop removed from the start:

".For standalone {CENTRAL}, enter the following command:"


* Replace `<CONTROLLER_USER>` and `<CONTROLLER_PWD>` with the user name and password for the `kie-server` role that you defined earlier in this procedure.
* Replace `<KIE_SERVER_ID>` with a unique identifier.
* Replace `<CONTROLLER_HOST>:<CONTROLLER_PORT>` with the host and port (IP address) of the controller. If you use the same server for {KIE_SERVER} and the controller, `<CONTROLLER_HOST>:<CONTROLLER_PORT>` is `localhost:8080`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion - swap positions of IP address and host and port, because we are indicating that the IP address needs the port declared.
s/with the host and port (IP address) of the controller/with the IP address (host and port) of the controller/

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, thanks.

ifeval::["{context}" == "install-on-jws"]
`_JWS_HOME_/tomcat/bin`
endif::[]
ifeval::["{context}" == "install-on-tomcat"]
`_TOMCAT_HOME_/tomcat/bin`
endif::[]
directory of the instance running the {HEADLESS_CONTROLLER}, create a readable `setenv.sh` file with the following content:
directory of the instance running the {HEADLESS_CONTROLLER}, create a readable `setenv.sh` file with the following content where `<USERNAME>` is {KIE_SERVER} user and `<USER_PWD>` is the password for that user:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/is {KIE_SERVER} user/is the {KIE_SERVER} user

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good catch, thanks.

endif::PAM[]
ifdef::DM[]
`__TEMP_DIR__/{PRODUCT_FILE}-kie-server-ee8/{PRODUCT_FILE}-kie-server-ee8/kie-server.war`
`__TEMP_DIR__/{{PRODUCT_FILE}-kie-server-ee8/kie-server.war`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicated "{"

emmurphy1 added a commit that referenced this pull request Jul 10, 2019
BXMSDOC-4148 Installing and configuring DM 7.4 and PAM 7.4 on EAP, JWS, and Tomcat
@emmurphy1 emmurphy1 deleted the BXMSDOC-4148-master branch January 30, 2020 12:47
emmurphy1 pushed a commit that referenced this pull request Dec 1, 2021
* New fields in audit data model

* SME comment

* SME review
emmurphy1 pushed a commit that referenced this pull request Dec 1, 2021
* New fields in audit data model

* SME comment

* SME review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants