Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add demo with files #10

Closed
wants to merge 1 commit into from
Closed

add demo with files #10

wants to merge 1 commit into from

Conversation

caub
Copy link

@caub caub commented May 5, 2017

small demo, I was testing a few MD5 libs, yours is considerably faster, nice work

I know it's not easy because all names are taken on npm, but I think js-md5 is not ideal, you could take https://www.npmjs.com/package/md5js maybe

@coveralls
Copy link

coveralls commented May 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d055959 on caub:master into 8b9a23c on emn178:master.

@coveralls
Copy link

coveralls commented May 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d055959 on caub:master into 8b9a23c on emn178:master.

@emn178
Copy link
Owner

emn178 commented May 8, 2017

There is already a demo using file. What's different?
I can't find a better name. md5js seems confused with md5.js.
thanks anyway.

@caub
Copy link
Author

caub commented May 8, 2017

just a demo to md5 files, you can check here https://caub.github.io/js-md5/demo/index.html

for the module name, it's just that imagine you have multiple dependencies like js-md5, js-buffer, js-opentype it's hard to read for me, I prefer to wrap the js anywhere at the end, but nevermind it's not frequent

@caub caub force-pushed the master branch 2 times, most recently from 2e58889 to dd1676e Compare May 8, 2017 14:36
@coveralls
Copy link

coveralls commented May 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling dd1676e on caub:master into 8b9a23c on emn178:master.

@coveralls
Copy link

coveralls commented May 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling dd1676e on caub:master into 8b9a23c on emn178:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f0d078e on caub:master into 8b9a23c on emn178:master.

1 similar comment
@coveralls
Copy link

coveralls commented May 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f0d078e on caub:master into 8b9a23c on emn178:master.

@caub
Copy link
Author

caub commented Jun 19, 2017

author doesn't want it

@caub caub closed this Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants