Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript types in repo #10

Closed
wants to merge 2 commits into from
Closed

Add typescript types in repo #10

wants to merge 2 commits into from

Conversation

hlehmann
Copy link

This would allow typescript users to directly have typings

@coveralls
Copy link

coveralls commented Jul 20, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 7aaab1d on hlehmann:patch-1 into ee3b386 on emn178:master.

@emn178
Copy link
Owner

emn178 commented Jul 21, 2017

There are other methods create/update/hex... do you want to add?
Here is an example https://github.com/emn178/js-sha3/blob/master/index.d.ts

demurgos
demurgos reviewed Nov 12, 2017
View reviewed changes
package.json
@@ -3,6 +3,7 @@
"version": "0.6.0",
"description": "A simple SHA-256 / SHA-224 hash function for JavaScript supports UTF-8 encoding.",
"main": "src/sha256.js",
"typings": "index.d.ts",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the package property should be types. typings was used by TS1.

@demurgos
Copy link

There are other methods create/update/hex... do you want to add?

Merging this PR might already be a good start but I agree that the type definitions should be complete. The documentation is not very clear so having formal type definitions would also help with this.

emn178 added a commit that referenced this pull request Nov 19, 2017
@emn178
Added
4e53548 
- support for web worker.
- typescript types. #10

Changed
- prevent webpack to require dependencies.
@emn178
Copy link
Owner

emn178 commented Nov 19, 2017

Add TypeScript support to v0.8.0

@emn178 emn178 closed this Dec 18, 2017
@hlehmann hlehmann deleted the patch-1 branch December 18, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demurgos demurgos demurgos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hlehmann @coveralls @emn178 @demurgos