Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: run linters #122

Merged
merged 6 commits into from
Sep 1, 2022
Merged

refactor: run linters #122

merged 6 commits into from
Sep 1, 2022

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Aug 30, 2022

Fix #120

@maelle maelle changed the title upkeep: run linters refactor: run linters Aug 30, 2022
@maelle
Copy link
Collaborator Author

maelle commented Aug 30, 2022

Only failures related to #121

@annakrystalli
Copy link
Collaborator

Are ready for a review on this PR?

Copy link
Collaborator

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really liking these linters! Will set up for EMODnetWCS also!

@maelle maelle marked this pull request as ready for review September 1, 2022 07:05
@codecov-commenter
Copy link

Codecov Report

Merging #122 (42062f9) into main (5d977e2) will increase coverage by 1.23%.
The diff coverage is 100.00%.

❗ Current head 42062f9 differs from pull request most recent head 2e72684. Consider uploading reports for the commit 2e72684 to get more accurate results

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   87.86%   89.09%   +1.23%     
==========================================
  Files           6        6              
  Lines         272      266       -6     
==========================================
- Hits          239      237       -2     
+ Misses         33       29       -4     
Impacted Files Coverage Δ
R/client.R 85.41% <100.00%> (+0.23%) ⬆️
R/info.R 95.55% <100.00%> (+6.66%) ⬆️
R/layer_attributes.R 90.78% <100.00%> (ø)
R/layers.R 85.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@maelle
Copy link
Collaborator Author

maelle commented Sep 1, 2022

@annakrystalli yes it's now ready!

Given some linters have false positives, for now it's not set up automatically.

@annakrystalli
Copy link
Collaborator

Do you just run them manually locally then? If so, should we add a note in the contributing guidelines about it if so so other devs know how to deploy them?

Copy link
Collaborator

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me. I've added my only comment to the PR discussion

@maelle maelle merged commit c1ac54a into main Sep 1, 2022
@maelle maelle deleted the linters branch September 1, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run new linters on codebase
3 participants