-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: run linters #122
Conversation
Only failures related to #121 |
Are ready for a review on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really liking these linters! Will set up for EMODnetWCS also!
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 87.86% 89.09% +1.23%
==========================================
Files 6 6
Lines 272 266 -6
==========================================
- Hits 239 237 -2
+ Misses 33 29 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@annakrystalli yes it's now ready! Given some linters have false positives, for now it's not set up automatically. |
Do you just run them manually locally then? If so, should we add a note in the contributing guidelines about it if so so other devs know how to deploy them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me. I've added my only comment to the PR discussion
Fix #120