Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom.php not working #770

Closed
cmgj74 opened this issue Jan 8, 2018 · 3 comments
Closed

zoom.php not working #770

cmgj74 opened this issue Jan 8, 2018 · 3 comments
Labels

Comments

@cmgj74
Copy link

cmgj74 commented Jan 8, 2018

Since about Feb 2017 zoom has been broken.

I think I found the fix:

This line:
get_feed_data_DMY_async(vis_feed_kwh_data_callback,null,kwhd,start,end,"day"); // get 5 years of daily kw_data

should be:

get_feed_data_DMY_async(vis_feed_kwh_data_callback,null,kwhd,start,end,"daily"); // get 5 years of daily kw_data

I saw this fixed here once...but it looks like it was lost.
emoncms/emoncmsorg@5900e4a#diff-94c2ec2f418ea0a1e4f47bc37a905cfb

I tested this in my lab, and it works the way it used to work with the above change.

pb66 added a commit that referenced this issue Jan 9, 2018
Corrected mode from "day" to "daily" as reported in #770
@pb66
Copy link
Collaborator

pb66 commented Jan 9, 2018

Hi, thanks for debugging and reporting. I suspect this was only ever fixed on the emoncmsorg repo. I've tried the same fix here and it works as expected. Thanks @cmgj74

ref ab41902#diff-e443846d35461a3175ed193ec6afdbaa

@pb66 pb66 closed this as completed Jan 9, 2018
@pb66 pb66 added the bug label Jan 9, 2018
pb66 added a commit that referenced this issue Jan 9, 2018
Corrected mode from "day" to "daily", same issue as #770, fixed in commit ab41902
@pb66
Copy link
Collaborator

pb66 commented Jan 9, 2018

Turns out the simplezoom was also broken with the same issue fixed in ab41902

@cmgj74
Copy link
Author

cmgj74 commented Jan 9, 2018

I finally had time to dig into it...glad I did! Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants