Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processlist buttons for inputs page #181

Merged
merged 3 commits into from
Apr 8, 2014
Merged

Processlist buttons for inputs page #181

merged 3 commits into from
Apr 8, 2014

Conversation

pb66
Copy link
Collaborator

@pb66 pb66 commented Apr 3, 2014

Hi, I have just changed how the new +,-,/,x feed functions get displayed on the main inputs page
This is before

image

And after

image

You can also see the changes using the "reset to zero" function in the Grid chain to using the "allow negative & allow positive pairs" in the Solar chain.

Paul

to replace the current workaround of using allow negative & allow positive together to zero a process chain.
Recently added /,x,-,+ feed functions and the reset functions currently show as uninformative grey tags on the process list chain on the inputs page, added 5 new functions to processlist 'keys' and added a 4th "type" combining the colour and label style of "+ input" type with the "link to vis" functionality of the "log to feed" type.
shortened "RESET" to "=0" to reduce size of button and match existing allow pos and allow neg tags
@Dave-McCraw
Copy link
Contributor

👍 - looks like you should change the third input so that >0 <0 becomes =0 in a couple of places though!

It makes me wonder whether "set to feed value" would be worthwhile (i.e. =0 +feed together). I suppose individual ops are more powerful, but perhaps not so intuitive.

@pb66
Copy link
Collaborator Author

pb66 commented Apr 3, 2014

yeah I changed them immediately after taking the screenshot as I had only left them there for comparison.
I did wonder about the "reset to input" option instead but whilst it does reduce "reset to zero" & "add feed" to one process step, but only IF you want the same input again, otherwise it's back to a 3 step process "allow pos & allow neg & add feed" unless we keep both 2 functions,
And that means 2 ways to do the same thing alot of the time and another entry on the dropdown, so I opted for simple.
What could make them more intuitive is if we can make the hover over display the feed name and value rather than type and id.

@TrystanLea
Copy link
Member

Awesome, thanks for fixing these

TrystanLea added a commit that referenced this pull request Apr 8, 2014
Processlist buttons for inputs page
@TrystanLea TrystanLea merged commit a88ba70 into emoncms:master Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants