Skip to content

Commit

Permalink
s/markAsNamedType/registerNamedType/ s/markAsNamedValue/registerNamed…
Browse files Browse the repository at this point in the history
…Value/
  • Loading branch information
emonkak committed Nov 19, 2014
1 parent 8bd458f commit 8f8f58b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ $dependencyGraph = (new DependencyResolver())
->registerType(IFoo::class, Foo::class)
->registerType(IBar::class, Bar::class)
->registerDynamicType(IQux::class)
->markAsNamedType(IBaz::class)
->registerNamedType(IBaz::class)
->execute([Bootstrapper::class]);
```

Expand Down
12 changes: 6 additions & 6 deletions src/DependencyResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@ public function registerDynamicType($typeName)
}

/**
* Marks to use name-based binding.
* Registers the type to use name-based binding.
*
* @param string $typeName The fully qualified class name.
* @return DependencyResolver
*/
public function markAsNamedType($typeName)
public function registerNamedType($typeName)
{
if (isset($this->namedTypes[$typeName])) {
throw new \InvalidArgumentException("`$typeName` is already marked as named type.");
throw new \InvalidArgumentException("`$typeName` is already registerd.");
}

$type = new \ReflectionClass($typeName);
Expand All @@ -76,15 +76,15 @@ public function markAsNamedType($typeName)
}

/**
* Marks to use name-based binding.
* Registers the value name to use name-based binding.
*
* @param string $valueName The name of constructor's parameter
* @return DependencyResolver
*/
public function markAsNamedValue($valueName)
public function registerNamedValue($valueName)
{
if (isset($this->namedValues[$valueName])) {
throw new \InvalidArgumentException("`$valueName` is already marked as named value.");
throw new \InvalidArgumentException("`$valueName` is already registerd.");
}

$this->namedValues[$valueName] = true;
Expand Down
2 changes: 1 addition & 1 deletion tests/ServiceProviderGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function testGenerate()
->registerType(IFoo::class, Foo::class)
->registerType(IBar::class, Bar::class)
->registerDynamicType(IQux::class)
->markAsNamedType(IBaz::class)
->registerNamedType(IBaz::class)
->execute([Bootstrapper::class]);

$source = $serviceProviderGenerator->generate($serviceProviderClass, $dependencyGraph);
Expand Down

0 comments on commit 8f8f58b

Please sign in to comment.