Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added metal support for macosx version (based on rust_minifb) #17

Merged
merged 1 commit into from
Mar 3, 2019
Merged

added metal support for macosx version (based on rust_minifb) #17

merged 1 commit into from
Mar 3, 2019

Conversation

Darky-Lucera
Copy link
Collaborator

@Darky-Lucera Darky-Lucera commented Mar 3, 2019

I added a compiler define USE_METAL_API to avoid removing support for old macos. So you must define it before compile the code for MacOs X mojave.

@emoon emoon merged commit d6a5245 into emoon:master Mar 3, 2019
@emoon
Copy link
Owner

emoon commented Mar 3, 2019

Awesome! Thanks a lot

@Darky-Lucera
Copy link
Collaborator Author

I would like to add some basic interaction events to miniFB (mouse & keyboard). I had implemented them for windows already , but I have seen that you have done something similar for rust_minifb.
Do you agree with this idea?

@emoon
Copy link
Owner

emoon commented Mar 5, 2019

Yeah that sounds like a good idea. For macOS and Linux it's likely easy to just port parts of that code as it's in C/ObjC anyway. The Windows version is written fully in Rust but it should be quite straightforward to adapt your code to the API if you want. One problem I noticed with the way I implemented the API in rust_minifb is that it "stalls" / is a bit slow to check the events on the main thread the way it's designed.

I'm not sure how to change the design or if it's worth it as the API for keyboard mouse is quite nice to use so I would like to have the C version in a similar direction.

@Darky-Lucera Darky-Lucera deleted the macosx_metal branch June 8, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants