Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports link_preview block #74

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Supports link_preview block #74

merged 4 commits into from
Apr 7, 2024

Conversation

rslhdyt
Copy link
Contributor

@rslhdyt rslhdyt commented Apr 4, 2024

This PR introduces support for the link_preview block from Notion.

https://developers.notion.com/reference/block#link-preview

@emoriarty emoriarty added enhancement New feature or request good first issue Good for newcomers labels Apr 6, 2024
@emoriarty
Copy link
Owner

emoriarty commented Apr 6, 2024

Hello @rslhdyt, thanks for your first contribution. But before merging the PR there are some missing points:

  • Update the supported blocks in the README file.
  • It is also missed an integration test but for that the VCR fixture file must be updated and you cannot do it. I'm the one with the API key. So, I'm doing that test.

@rslhdyt
Copy link
Contributor Author

rslhdyt commented Apr 7, 2024

Hi @emoriarty, I've updated the README and fixed a small typo in the spec.

BTW, thank you for this amazing work.

@emoriarty emoriarty merged commit cf9382c into emoriarty:main Apr 7, 2024
4 checks passed
@emoriarty
Copy link
Owner

emoriarty commented Apr 7, 2024

Thanks for your collaboration 🎉. The feature will be published in the new minor version along with this other issue #76. If you feel keen to, you can collaborate to support the mention block 😉. It will be much appreciated ❤️ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants