New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converts document-heading-second-row into a dl (#655). #663

Merged

wulman16 merged 1 commit into main from wrap_document_heading_2nd_row_dl_655

Jul 23, 2020

Contributor

bwatson78 commented Jul 22, 2020 •

edited

Loading

app/assets/stylesheets/lux/_results_list.scss: points to dl instead of div and adjusts dl's inherent bottom margin.
app/views/catalog/_index_header.html.erb: swaps out to div.
spec/system/view_search_results_spec.rb: adds test that checks for dl wrapper.


          Converts document-heading-second-row into a dl (#655).

6600a33

bwatson78 mentioned this pull request

Add definition list to search result page component #655

Closed

2 tasks

Contributor Author

bwatson78 commented Jul 23, 2020

wulman16 approved these changes

View reviewed changes

wulman16 merged commit ec71702 into main

wulman16 deleted the wrap_document_heading_2nd_row_dl_655 branch

July 23, 2020 13:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment