-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncutil - window size for reading datastream information can be too small #17
Comments
@ghukill thanks for opening this; I think we may be adding some notes here soon with some other related issues and/or edge cases we've been running into. |
I'm just adding some errors I encountered:
When I actually catch the error for the one above, i get:
|
Also fixes omit-checksum filter for case when data is a generator
I think setting a larger size for the chunk used for datastream info should be fine, and it shouldn't cause an issue with the regex since we're splitting on datastream start and end - that chunk shouldn't ever include datastream info for a previous datastream. My testing indicated that it worked fine for objects that can be successfully synced (excepting the problem record mentioned above, which seems to have other issues). |
Creating new issue based on conversations from Issue #15.
The problem arises when the datastream information is particularly long (e.g. labels), causing it be longer than the moving window for reading datastream information.
Bumping the window size on line 206 and lines 252-255 from
200
/250
to something like750
worked for a particular set of objects with long datastream labels, but might not be a permanent solution.The text was updated successfully, but these errors were encountered: