Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3 support #19

Merged
merged 7 commits into from Feb 19, 2016
Merged

Add Python 3 support #19

merged 7 commits into from Feb 19, 2016

Conversation

ellmetha
Copy link
Contributor

No description provided.

@rlskoeser
Copy link
Contributor

Thanks for taking this on! We haven't really started looking into python 3 yet, unfortunately, and I haven't taken the time to look into it as I should. It looks like by using six and the changes you've made, the same code can be run on both python 2.6/2.7 and 3.x? (So great that Travis-CI can test all of those versions.)

Are there any caveats or concerns, things we need to pay attention to moving forward with these changes to make sure we maintain python 3 compatabilty?

@ellmetha
Copy link
Contributor Author

Hi ;)

the same code can be run on both python 2.6/2.7 and 3.x? (So great that Travis-CI can test all of those versions.)

Yes. I made sure that the code can run under the following versions of Python : 2.6, 2.7, 3.3, 3.4 and 3.5.

Are there any caveats or concerns, things we need to pay attention to moving forward with these changes to make sure we maintain python 3 compatabilty?

Not necessarily if you're used to write Python 2-3 compatible code. As you noticed, the proposed changes make heavy use of six helpers. I also added tox to the project in order to ease testing against different versions of Python.

@rlskoeser rlskoeser merged commit e832ae0 into emory-libraries:master Feb 19, 2016
@rlskoeser rlskoeser mentioned this pull request Feb 19, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e832ae0 on erudit:python3-support into ** on emory-libraries:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants