Skip to content

Commit

Permalink
Added option & fallback AMP props to the list of valid props (#2232)
Browse files Browse the repository at this point in the history
* add "option", "fallback" amp html property to whitelist

* Create wet-apes-report.md

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
  • Loading branch information
ka2jun8 and Andarist committed Jan 30, 2021
1 parent b62647e commit f3c2e81
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/wet-apes-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@emotion/is-prop-valid": minor
---

Added `option` & `fallback` AMP props to the list of valid props.
7 changes: 7 additions & 0 deletions packages/is-prop-valid/src/props.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ const props = {
autoSave: true,
// color is for Safari mask-icon link
color: true,
// used in amp html for indicating the fallback behavior
// https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/placeholders/
fallback: true,
// https://html.spec.whatwg.org/multipage/interaction.html#inert
inert: true,
// itemProp, itemScope, itemType are for
Expand All @@ -199,7 +202,11 @@ const props = {
itemID: true,
itemRef: true,
// used in amp html for eventing purposes
// https://amp.dev/documentation/guides-and-tutorials/learn/common_attributes/
on: true,
// used in amp html for indicating that the option is selectable
// https://amp.dev/documentation/components/amp-selector/
option: true,
// results show looking glass icon and recent searches on input
// search fields in WebKit/Blink
results: true,
Expand Down

0 comments on commit f3c2e81

Please sign in to comment.