Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with auto-labelling crashing on $ at runtime #1451

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Aug 1, 2019

fixes #1448

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2019

🦋 Changeset is good to go

Latest commit: e03ab83

We got this.

Not sure what this means? Click here to learn what changesets are.

@Andarist Andarist force-pushed the fix/dollar-in-labels branch 2 times, most recently from eb80fee to c8094d2 Compare August 2, 2019 14:07
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1451 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/core/src/jsx.js 100% <100%> (ø) ⬆️
packages/babel-plugin-emotion/src/utils/label.js 97.87% <100%> (+0.09%) ⬆️

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit 4a3b18a into master Aug 2, 2019
@emmatown emmatown deleted the fix/dollar-in-labels branch August 2, 2019 22:49
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[babel-plugin-emotion] Dollar sign $ breaks CSS
2 participants