Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings about using illegal escape sequances #1478

Merged
merged 5 commits into from
Aug 23, 2019

Conversation

Andarist
Copy link
Member

More context - #1354 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2019

🦋 Changeset is good to go

Latest commit: 14a5c0a

We got this.

Not sure what this means? Click here to learn what changesets are.

@Andarist Andarist force-pushed the warnings/unescaped-templates branch from ce0063d to 61dfd67 Compare August 21, 2019 21:51
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #1478 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/serialize/src/index.js 100% <100%> (ø) ⬆️
packages/styled-base/src/index.js 100% <100%> (ø) ⬆️
packages/core/src/context.js 100% <0%> (ø) ⬆️

@Andarist
Copy link
Member Author

Not sure why flow is failing on CI, my PR shouldn't affect that.

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit 66cda64 into master Aug 23, 2019
@emmatown emmatown deleted the warnings/unescaped-templates branch August 23, 2019 21:25
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
* Add warnings about using illegal escape sequances

* Fix things

* Add changesets

* sequance -> sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants