Add type definition for useTheme from emotion-theming #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 25ea11d We got this. Not sure what this means? Click here to learn what changesets are. |
Andarist
reviewed
Sep 17, 2019
| @@ -0,0 +1 @@ | |||
| Add type for useTheme hook in emotion-theming | |||
There was a problem hiding this comment.
could you mention here that this is about TS types?
There was a problem hiding this comment.
Sure, I've rephrased this to be clearer. Can you take a look?
Andarist
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR is adding TypeScript type definition for
useThemehook.Why:
The type definition was completely missing which prevents us from using
useThemein a TypeScript project.How:
Added the definition + attempted to write a test for it. Let me know if it looks OK.
Checklist: