Add dev warning about keyframes being interpolated into plain strings. #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 8c8e266 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
|
|
I think I'd rather have a dev warning about this because running this on all string styles. It's fine when it's only for the values of a couple properties on object styles but for every string style, I'd rather avoid it in production. |
Andarist
force-pushed
the
keyframes-into-strings
branch
from
453ac6b
to
4c15290
Compare
Andarist
changed the title
|
@mitchellhamilton adjusted |
emmatown
reviewed
Oct 21, 2019
Andarist
force-pushed
the
keyframes-into-strings
branch
from
4c15290
to
6528d67
Compare
Andarist
force-pushed
the
keyframes-into-strings
branch
from
6528d67
to
8c8e266
Compare
Merged
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably the preferred way to write this would be to wrap the thing in
csscall which can handle interpolatedkeyframeswithout falling back into regexp extraction.It's slightly weird to me though that this is allowed when using object styles but it is not when using plain strings. I can think of an argument for this (object values being shorter and not needing
csswrapping beside this one thing), but this looks inconsistent as part of the API. So if we decide not to merge this because of performance reasons we should at least add a dev warning about this.EDIT:// changed the PR to introduce a dev warning instead of regexp matching all strings