New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow labelFormat
option to be a function
#1651
Conversation
🦋 Changeset is good to goLatest commit: 7b15d76 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b15d76:
|
Codecov Report
|
if (typeof labelFormat === 'function') { | ||
return labelFormat({ | ||
name: sanitizedName, | ||
filename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we call this path
to distinguish it from the filename used in the string form of labelFormat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, changed.
cf7c125
to
7b15d76
Compare
* Allow `labelFormat` option to be a function * Change name of filename argument to path in function labelFormat
closes #1559