Fixed label extraction from the stack traces in FireFox and Safari #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 948b34c We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
commented
Jan 11, 2020
| @@ -158,7 +158,7 @@ export const jsx: typeof React.createElement = function( | |||
| ) | |||
| if (!match) { | |||
| // safari and firefox | |||
| match = error.stack.match(/^.*\n([A-Z][A-Za-z$]+)@/) | |||
| match = error.stack.match(/.*\n([A-Z][A-Za-z$]+)@/) | |||
There was a problem hiding this comment.
Example stack trace which was failing:
jsx@http://localhost:3000/_next/static/development/pages/theme_ui.js?ts=1578745166666:440:17
jsx$$1@http://localhost:3000/_next/static/development/pages/theme_ui.js?ts=1578745166666:2777:60
TestThemeUI@http://localhost:3000/_next/static/development/pages/theme_ui.js?ts=1578745166666:23:62
renderWithHooks@http://localhost:3000/_next/static/development/dll/dll_d6a88dbe3071bd165157.js?ts=1578745166666:16511:27
mountIndeterminateComponent@http://localhost:3000/_next/static/development/dll/dll_d6a88dbe3071bd165157.js?ts=1578745166666:19045:13
The Chrome one is not matching with ^ at the beginning, so this should be OK here too.
Codecov Report
|
emmatown
approved these changes
Jan 14, 2020
Merged
|
This is still an issue in Prod. Is this getting release soon? |
|
This has been released few months ago - if u are still experiencing problems with that please create a new issue with a runnable repro case attached to it. |
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes system-ui/theme-ui#538