Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types folder to published files for native #1716

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

META-DREAMER
Copy link
Contributor

@META-DREAMER META-DREAMER commented Jan 12, 2020

What: Adding types folder to files in package.json for @emotion/native

Why: So typings can be published to NPM and consumed by users of the package

How: Added 'types' to the files array in package.json

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete N/A
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2020

🦋 Changeset is good to go

Latest commit: af8908a

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af8908a:

Sandbox Source
Emotion Configuration

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit cb637e6 into emotion-js:next Jan 14, 2020
@META-DREAMER META-DREAMER deleted the next branch January 16, 2020 23:03
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
* Add types folder to published files for native

* Add changeset for emotion/native typings

* Include only definition files in published package for @emotion/native typings
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants