Change the key of a global key (indicating the @emotion/react has been already loaded) to include the major version #1981
Conversation
…n already loaded) to include the major version
🦋 Changeset is good to goLatest commit: a309c3c We got this. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -1,4 +1,5 @@ | |||
| // @flow | |||
| import pkg from '../package.json' | |||
There was a problem hiding this comment.
this is causing the whole package.json to be inlined to the bundle, but it's also only referenced from the dev-only branch and that object is totally static, so it should be a prime candidate for production DCE
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a309c3c:
|
Yeah, I have mixed feelings about it as well - the good thing though is that we can always drop it if we find to cause more harm than good. |
…n already loaded) to include the major version (emotion-js#1981)
In the future, it should be possible to upgrade your own code to Emotion 12 but still use, for example, Storybook based on Emotion 11 without this warning popping up. Actually there might be other problems with such setup and it might not work for some reason (but hopefully it would) - don't want to focus on unknown problems, because I can't imagine how this would potentially break on my own, so this is the least we can do right now until other issues arise in the future.