RFC: Expose interface for custom CSSObject declaration #2023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Modifications to
@emotion/serialize/types
so that the user may specify a customCSSObject
declaration in preference to the default.Why:
How:
The existing
CSSObject
is renamed toDefaultCSSObject
. A new, empty interface namedCustomCSSObject
is added. Finally, a new type namedCSSObject
is exported that takes the value ofCustomCSSObject
is it's provided, otherwiseDefaultCSSObject
. Users can augmentCustomCSSObject
in their project to override the value ofCSSObject
globally. This shouldn't have any impact on users who don't provide their own declaration.Checklist:
I'm not sure if/how this can be tested without splitting
dtslint
into two stages, since declaring aCustomCSSObject
anywhere changes the value globally. Feedback appreciated!