New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grammar in package-summary.mdx #2308
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9e96d42:
|
There also seems to be an incomplete sentence in the
Not sure what it accepts. If it's wanted, feel free to throw me a full sentence and I can add it to this PR. |
@@ -17,11 +17,11 @@ Depends on @emotion/react | |||
## @emotion/css | |||
|
|||
Contains a framework agnostic version of Emotion. Has different functionality and APIs from @emotion/react and doesn’t work the same way under the hood. | |||
Depends on @emotion/cache which which can be customised by creating a custom instance at @emotion/css/create-instance | |||
Depends on @emotion/cache which can be customized by creating a custom instance at @emotion/css/create-instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both "customized" and "customised" are correct - the former is used by American English and the latter is British.
@mitchellhamilton do you have any preference over this? to which flavor Australian is closer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have a strong preference, American is probably the better one to use to be consistent with what APIs generally use (e.g. color
in CSS).
Fixed double `which` and converted `customise` to `customize` to be consistent with this PR: emotion-js#1870
What:
Fixed double
which
and convertedcustomise
tocustomize
to be consistent with this PR: #1870Why:
Makes it easier to read.
How:
By using the keyboard.
Checklist: