Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in package-summary.mdx #2308

Merged
merged 2 commits into from Jul 10, 2022
Merged

Fix grammar in package-summary.mdx #2308

merged 2 commits into from Jul 10, 2022

Conversation

flugg
Copy link
Contributor

@flugg flugg commented Mar 24, 2021

What:
Fixed double which and converted customise to customize to be consistent with this PR: #1870

Why:
Makes it easier to read.

How:
By using the keyboard.

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2021

⚠️ No Changeset found

Latest commit: 9e96d42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 24, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e96d42:

Sandbox Source
Emotion Configuration

@flugg
Copy link
Contributor Author

flugg commented Mar 24, 2021

There also seems to be an incomplete sentence in the @emotion/cache paragraph:

...can create another instance of @emotion/css and it accepts
Depended upon by @emotion/react and @emotion/css

Not sure what it accepts. If it's wanted, feel free to throw me a full sentence and I can add it to this PR.

@@ -17,11 +17,11 @@ Depends on @emotion/react
## @emotion/css

Contains a framework agnostic version of Emotion. Has different functionality and APIs from @emotion/react and doesn’t work the same way under the hood.
Depends on @emotion/cache which which can be customised by creating a custom instance at @emotion/css/create-instance
Depends on @emotion/cache which can be customized by creating a custom instance at @emotion/css/create-instance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both "customized" and "customised" are correct - the former is used by American English and the latter is British.

@mitchellhamilton do you have any preference over this? to which flavor Australian is closer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a strong preference, American is probably the better one to use to be consistent with what APIs generally use (e.g. color in CSS).

Fixed double `which` and converted `customise` to `customize` to be consistent with this PR: emotion-js#1870
@srmagura srmagura enabled auto-merge (squash) July 10, 2022 13:57
@srmagura srmagura merged commit c9a1195 into emotion-js:main Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants