Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove selection styles in the doc #2332

Merged
merged 1 commit into from Apr 8, 2021

Conversation

troywith77
Copy link
Contributor

@troywith77 troywith77 commented Apr 5, 2021

What: Removes the selection styles on pre and code elements to approve readability.

Why: It's quite unreadable when selecting text on these elements,
image

How: By removing the ::selection selectors on these elements.

I'm encountering this issue when I'm reading the doc. If the design needs to be updated, I'd be happy to do it. Please feel free to close this PR if it's not necessary.

Checklist:

  • Documentation
  • Tests N/A
  • Code complete
  • Changeset N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2021

⚠️ No Changeset found

Latest commit: aff31c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aff31c1:

Sandbox Source
Emotion Configuration

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@troywith77
Copy link
Contributor Author

thanks @Andarist! Do you think we can get this merged?

@Andarist Andarist merged commit ad58eab into emotion-js:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants