Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Keyframes type from @emotion/react #2577

Merged
merged 5 commits into from Dec 8, 2021

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Dec 7, 2021

What:

Export Keyframes type from @emotion/core for v10.

Why:

In order to reference Keyframes without having to add a dependency to @emotion/serialize. See storybookjs/storybook#16905 for more context.

How:

N/A

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete N/A
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2021

🦋 Changeset detected

Latest commit: 0033cd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0033cd5:

Sandbox Source
Emotion Configuration

@Methuselah96 Methuselah96 changed the title Export Keyframes type from @emotion/core Export Keyframes type from @emotion/react Dec 8, 2021
@Andarist Andarist merged commit 04681a5 into emotion-js:main Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
@Methuselah96 Methuselah96 deleted the export-keyframes-type branch December 8, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants