Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a dedicated error for a situation when toHaveStyleRule receives an array #2749

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

Andarist
Copy link
Member

improves DX around a situation reported here: #1463 (comment)

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2022

🦋 Changeset detected

Latest commit: c407aa5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/jest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c407aa5:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #2749 (c407aa5) into main (62dd16b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
packages/jest/src/matchers.js 97.43% <100.00%> (+0.13%) ⬆️

Copy link
Member

@srmagura srmagura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Weird about the jest issue btw...

@Andarist
Copy link
Member Author

I've checked Jest 26 and that parser was relying more heavily on Prettier itself back then - that's why it probably worked. I suspect that it just handles JSX by default. Right now they are using babelCore.parseSync there and it comes with the whole baggage of config loading - that's probably why they have changed that, they have wanted to parse non-standard syntax etc. Appropriately loading configs, especially in monorepos, is quite cumbersome though - if you want to do it automatically, as there are many ways people could configure it.

@Andarist Andarist merged commit fd22cac into main Jun 7, 2022
@Andarist Andarist deleted the tohavestylerule-array-error branch June 7, 2022 09:29
@github-actions github-actions bot mentioned this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants