-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds documentation for eslint plugin react #2882
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 90ca4cd:
|
Thanks @chrisweb. I improved the writing some / removed 2 of the ESLint config examples since I felt they were redundant. |
@srmagura ok thank you for checking it out personally I would have kept the yaml example, because I sometimes find it hard to find the correct way of converting a rule into yaml when all you have is the json version (if maybe you are not super experienced with yaml object / array notations but your team used yaml for all configuration files), this is why I added that example to ensure it is really a no brainer for anyone to get this issue fixed quickly... but it is your project, I can see why you removed it and won't be angry if you keep it out ;) |
What:
adds documentation for eslint plugin react
Why:
To help users that use both emotion and eslint with the react plugin (> 7.31.1) to fix the linting problem they will encounter, more about it in this ticket: #2878 (comment)
How:
After filling a ticket #2878 (comment) to demonstrate and discuss the problem, I created the different eslint configuration files locally and tested them in my project to verify the described solution works, then I wrote the documentation based on them
Checklist: