Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to babel-macros 1.0.0 #298

Merged
merged 3 commits into from Sep 8, 2017
Merged

Conversation

kentcdodds
Copy link
Contributor

What: upgrade to babel-macros 1.0.0

Why: So folks get nice error messages

How: Add babel-macros dep so we can get the createMacro function, and use it.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete

@codecov
Copy link

codecov bot commented Sep 8, 2017

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          21       21           
  Lines         966      966           
  Branches      260      260           
=======================================
  Hits          873      873           
  Misses         75       75           
  Partials       18       18
Impacted Files Coverage Δ
packages/babel-plugin-emotion/src/macro-styled.js 100% <100%> (ø) ⬆️
packages/babel-plugin-emotion/src/macro.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d951f9...6c7b216. Read the comment docs.

@tkh44
Copy link
Member

tkh44 commented Sep 8, 2017

Thanks @kentcdodds

@tkh44 tkh44 merged commit 6d49017 into emotion-js:master Sep 8, 2017
@kentcdodds kentcdodds deleted the patch-1 branch September 8, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants