Fix typing for emotion package #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2018
emmatown
pushed a commit
that referenced
this pull request
May 24, 2018
**What**: Add typing for create-emotion-styled package **Why**: To allow TS users to use create-emotion-styled **How**: By consulting with glamorous typing and old react-emotion typing **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [N/A] Documentation - [ ] Tests - [ ] Code complete I'm not sure this is complete typing. Could you give me more idea for testing? What usecases did I miss? After typing for this package is completed and #667 is merged without complex problems, I want to fix `react-emotion` typing and add `preact-emotion` typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fix typing for emotion package
Why: Original typing does not support autocompletion, and have redundant types after create-emotion is typed.
How: Using create-emotion typing
Checklist: