Update HighSpeedNetIO to take in two ports instead of one #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
commented
Apr 16, 2021
| int send_port; | ||
| int recv_port; | ||
|
|
||
| HighSpeedNetIO(const char *address, int send_port, int recv_port, bool quiet = true) |
There was a problem hiding this comment.
This is the main change here
|
I updated the indentation and some minor formatting so that they are consistent with the rest of the code. Everything else looks great! Thanks! |
|
@wangxiao1254 do you have the formatting settings that you use for this repo? That way I can use the same the next time I create PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a series of code quality fixes
Changes in this PR:
HighSpeedNetIO's constructor only takes in one port but it ends up using a second port (port+1). This could causes harder to catch bugs. The fix here is to update the constructor to take in two ports and update the caller to pass in the values correctly.I highly recommend reviewing the PR with ?w=1 (ignores whitespace diff). https://github.com/emp-toolkit/emp-tool/pull/119/files?w=1