Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Functions introductory notebook #211

Merged
merged 15 commits into from
Apr 17, 2024
Merged

Expand Functions introductory notebook #211

merged 15 commits into from
Apr 17, 2024

Conversation

edoardob90
Copy link
Member

@edoardob90 edoardob90 commented Mar 26, 2024 •
edited

Fixes #118

@edoardob90 edoardob90 linked an issue Mar 26, 2024 that may be closed by this pull request
Functions: provide intermediate exercises #118
Closed
@edoardob90 edoardob90 changed the title Functions Expand Functions material Mar 26, 2024
@edoardob90 edoardob90 marked this pull request as ready for review March 27, 2024 16:11
@edoardob90 edoardob90 changed the title Expand Functions material Expand Functions introductory notebook Mar 27, 2024
despadam
despadam requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@despadam despadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, only left comments about a few details.

tutorial/tests/test_functions.py Outdated Show resolved Hide resolved
functions.ipynb Outdated Show resolved Hide resolved
functions.ipynb Show resolved Hide resolved
@despadam despadam added the upcoming tutorial Stuff to work on/fix before the next tutorial label Apr 2, 2024
@edoardob90
Copy link
Member Author

@despadam Thanks for the comments! I addressed them and fixed a few conflicts that came up. Have a second look when you've some time.

@edoardob90 edoardob90 self-assigned this Apr 3, 2024
@edoardob90 edoardob90 requested a review from despadam April 3, 2024 08:29
despadam
despadam requested changes Apr 4, 2024
View reviewed changes
functions.ipynb Show resolved Hide resolved
@despadam despadam merged commit 08a2244 into main Apr 17, 2024
1 check passed
@despadam despadam deleted the 118-functions-provide-intermediate-exercises branch April 17, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@despadam despadam despadam approved these changes

Assignees

@edoardob90 edoardob90

Labels
upcoming tutorial Stuff to work on/fix before the next tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions: provide intermediate exercises
2 participants
@edoardob90 @despadam