MERGE PR: better comprehension highlighting (#7861) #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding formatter class and test harness working, but ugly better var naming feedback moving string formatting to Comoprehension/lib Co-authored-by: Peter Kong <pkong@quill.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding formatter class and test harness
working, but ugly
better var naming
feedback
moving string formatting to Comoprehension/lib
Co-authored-by: Peter Kong pkong@quill.org
WHAT
WHY
HOW
Screenshots
(If applicable. Also, please censor any sensitive data)
Notion Card Links
(Please provide links to any relevant Notion card(s) relevant to this PR.)