Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Change
enabled_for_admins
toenabled_for_staff
in both name and function.WHY
When I started working on implementing the frontend feature that utilizes this code, I realized that
enabled_for_admins
was probably meant to turn on features for Quill admins (ie, staff members), not district admins. I checked with @dandrabik and he confirmed that this was correct, so I updated both the functionality and the naming to hopefully be clearer.HOW
Add a migration to change the name, change everywhere we reference that column, and change the logic to check for staff members and not admins.
Screenshots
(If applicable. Also, please censor any sensitive data)
Notion Card Links
https://www.notion.so/quill/Change-enabled_for_admins-to-enabled_for_staff-on-App-Settings-c66650b28e6d456e88d1ec4b9f46f7b1