Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename column on app settings #7898

Merged

Conversation

emilia-friedberg
Copy link
Member

@emilia-friedberg emilia-friedberg commented Jul 9, 2021

WHAT

Change enabled_for_admins to enabled_for_staff in both name and function.

WHY

When I started working on implementing the frontend feature that utilizes this code, I realized that enabled_for_admins was probably meant to turn on features for Quill admins (ie, staff members), not district admins. I checked with @dandrabik and he confirmed that this was correct, so I updated both the functionality and the naming to hopefully be clearer.

HOW

Add a migration to change the name, change everywhere we reference that column, and change the logic to check for staff members and not admins.

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

https://www.notion.so/quill/Change-enabled_for_admins-to-enabled_for_staff-on-App-Settings-c66650b28e6d456e88d1ec4b9f46f7b1

PR Checklist Your Answer
Have you added and/or updated tests? YES
Have you deployed to Staging? NO - non-app change
Self-Review: Have you done an initial self-review of the code below on Github? YES
Design Review: If applicable, have you compared the coded design to the mockups? N/A

Copy link
Member

@dandrabik dandrabik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Thanks for making this change.

@emilia-friedberg emilia-friedberg merged commit c373003 into develop Jul 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/change-enabled-for-admins-to-enabled-for-staff branch July 12, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants