Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic code consolidation #94

Merged
merged 20 commits into from
Oct 21, 2019
Merged

Topic code consolidation #94

merged 20 commits into from
Oct 21, 2019

Conversation

yvespeirsman
Copy link
Collaborator

WHAT

Consolidated experimental code from Jupyter notebooks and scripts to the quillnlp package.

WHY

Code in the package is easier to reuse and makes it easier to build new NLP pipelines.

HOW

The quillnlp package now has several subpackages. The code is organized as follows:

  • quillnlp/allennlp: the code for our AllenNLP experiments
  • quillnlp/data: functions for processing our data sets (e.g. data diversity)
  • quillnlp/models: the core classes and functions for NLP models such as BERT
  • quillnlp/preprocessing: functions for preprocessing our data sets (e.g. coreference and SRL steps)

Copy link
Member

@dandrabik dandrabik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me, sorry for this very slow review. I'm going to squash and merge this branch.

@dandrabik dandrabik merged commit 405041d into master Oct 21, 2019
@happythenewsad happythenewsad deleted the topic-code-consolidation branch October 17, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants