fix: export premature close error (#480)

empiricaly · Jan 1, 2024 · cd48506 · cd48506
1 parent b32b95a
commit cd48506
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 17 deletions.
diff --git a/.changeset/export-premature-close.md b/.changeset/export-premature-close.md
@@ -0,0 +1,15 @@
+---
+"@empirica/core": patch
+---
+
+`empirica export` could fail with a "Premature close" error (#474). This seems
+to be originating from a bug in the `node-fetch` package, which is used to
+polyfill `fetch` in Node.js. This upgrades Node.js to v20+, which includes
+native `fetch` support. We still have the `cross-fetch` polyfill for projects
+that have not updated to Node.js v20+ yet. Export uses a vendored project which
+has been updated to use the latest Node.js version, so it does not require the
+entire experiment to be updated for it to use Node.js v20+.
+
+See the following issues on `node-fetch` for more details:
+https://github.com/node-fetch/node-fetch/issues/1767
+https://github.com/node-fetch/node-fetch/issues/1576
diff --git a/.github/actions/upload-empirica-cli/package.json b/.github/actions/upload-empirica-cli/package.json
@@ -12,8 +12,8 @@
   "author": "Nicolas Paton",
   "private": true,
   "volta": {
-    "node": "16.17.0",
-    "npm": "8.15.0"
+    "node": "20.10.0",
+    "npm": "10.2.3"
   },
   "dependencies": {
     "@actions/core": "1.10.0",

diff --git a/internal/templates/source/callbacks/package.json b/internal/templates/source/callbacks/package.json
@@ -7,8 +7,8 @@
     "serve": "node --trace-warnings --enable-source-maps --unhandled-rejections=warn-with-error-code index.js"
   },
   "volta": {
-    "node": "16.17.0",
-    "npm": "8.15.0"
+    "node": "20.10.0",
+    "npm": "10.2.3"
   },
   "dependencies": {
     "@empirica/core": "latest",

diff --git a/internal/templates/source/export/package.json b/internal/templates/source/export/package.json
@@ -11,8 +11,8 @@
   },
   "version": "1.0.0",
   "volta": {
-    "node": "16.17.0",
-    "npm": "8.15.0"
+    "node": "20.10.0",
+    "npm": "10.2.3"
   },
   "dependencies": {
     "@empirica/core": "latest",

diff --git a/internal/templates/source/react/package.json b/internal/templates/source/react/package.json
@@ -8,8 +8,8 @@
     "serve": "vite preview"
   },
   "volta": {
-    "node": "16.17.0",
-    "npm": "8.15.0"
+    "node": "20.10.0",
+    "npm": "10.2.3"
   },
   "dependencies": {
     "@empirica/core": "latest",

diff --git a/lib/@empirica/core/package.json b/lib/@empirica/core/package.json
@@ -129,8 +129,8 @@
     }
   },
   "volta": {
-    "node": "16.17.0",
-    "npm": "8.15.0"
+    "node": "20.10.0",
+    "npm": "10.2.3"
   },
   "engines": {
     "node": ">= 16.17.0"

diff --git a/lib/admin-ui/package.json b/lib/admin-ui/package.json
@@ -29,8 +29,8 @@
     "url": "https://github.com/empiricaly/empirica/issues"
   },
   "volta": {
-    "node": "18.16.0",
-    "npm": "9.7.1"
+    "node": "20.10.0",
+    "npm": "10.2.3"
   },
   "devDependencies": {
     "@julr/unocss-preset-forms": "0.0.5",

diff --git a/package-lock.json b/package-lock.json
diff --git a/tests/stress/experiment/client/package.json b/tests/stress/experiment/client/package.json
@@ -26,7 +26,7 @@
   },
   "version": "0.0.0",
   "volta": {
-    "node": "16.17.0",
-    "npm": "8.15.0"
+    "node": "20.10.0",
+    "npm": "10.2.3"
   }
 }
diff --git a/tests/stress/experiment/server/package.json b/tests/stress/experiment/server/package.json
@@ -14,7 +14,7 @@
     "serve": "node --trace-warnings --enable-source-maps --unhandled-rejections=warn-with-error-code index.js"
   },
   "volta": {
-    "node": "16.17.0",
-    "npm": "8.15.0"
+    "node": "20.10.0",
+    "npm": "10.2.3"
   }
 }