fix bug, pass date/groupby/metric column to dimension modal

empower-ai · Sep 4, 2023 · 53951e0 · 53951e0
1 parent 84a7b40
commit 53951e0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/frontend/src/components/main-dashboard/MainDashboard.tsx b/frontend/src/components/main-dashboard/MainDashboard.tsx
@@ -408,6 +408,9 @@ export default function MainDashboard() {
             fileId={fileId}
             targetDirection={targetDirection}
             selectedColumns={selectedColumns}
+            dateColumn={dateColumn}
+            groupByColumns={groupByColumns}
+            metricColumn={metricColumn}
             baseDateRange={baseDateRange}
             comparisonDateRange={comparisonDateRange}
             dataSourceType={dataSourceType}

diff --git a/.../src/components/main-dashboard/dimention-slice-detail-modal/DimentionSliceDetailModal.tsx b/.../src/components/main-dashboard/dimention-slice-detail-modal/DimentionSliceDetailModal.tsx
@@ -28,6 +28,7 @@ import { DataSourceType } from "../../../types/data-source";
 import {
   ColumnConfig,
   DateRangeConfig,
+  MetricColumn,
   TargetDirection,
 } from "../../../types/report-config";
 import { MetricOverviewTable } from "../MetricOverviewTable";
@@ -39,6 +40,9 @@ interface Props {
   selectedColumns: {
     [key: string]: ColumnConfig;
   };
+  dateColumn: string;
+  metricColumn: MetricColumn,
+  groupByColumns: string[];
   baseDateRange: DateRangeConfig;
   comparisonDateRange: DateRangeConfig;
   dataSourceType: DataSourceType;
@@ -48,6 +52,9 @@ export function DimensionSliceDetailModal({
   targetDirection,
   fileId,
   selectedColumns,
+  dateColumn,
+  groupByColumns,
+  metricColumn,
   baseDateRange,
   comparisonDateRange,
   dataSourceType,
@@ -76,6 +83,9 @@ export function DimensionSliceDetailModal({
           body: JSON.stringify({
             fileId,
             baseDateRange,
+            dateColumn,
+            groupByColumns,
+            metricColumn,
             comparisonDateRange,
             selectedColumns,
             segmentKey: selectedSliceKey,