Skip to content

Commit

Permalink
Rename the calculation mode and set the default mode to noticeable se…
Browse files Browse the repository at this point in the history
…gments only
  • Loading branch information
dyang415 committed Aug 29, 2023
1 parent ac7db88 commit 82898b4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,20 +108,19 @@ export default function TopDimensionSlicesTable({
<Flex justifyContent="start" className="gap-2 w-auto">
{showCalculationMode && (
<>
<Text>Calculation Mode:</Text>
<Text>Mode:</Text>
<Select
className="w-[150px] min-w-[160px]"
value={mode}
onValueChange={(e) => {
setTopDriverMode(e as any);
}}
>
<SelectItem value="impact">Impact Mode</SelectItem>
<SelectItem value="outlier">Outlier Mode</SelectItem>
<SelectItem value="impact">All Top Segments</SelectItem>
<SelectItem value="outlier">Noticeable Only</SelectItem>
</Select>
<TooltipIcon
text="Impact Mode: Show segments with the highest impact on the metric.
Outlier Mode: Show segments with the highest outlier score."
text="All Top Segments: Show all segments with the top change on the metric.
Noticeable Only: Show noticeable segments recommended by the algorithm."
/>
</>
)}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/store/comparisonInsight.ts
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ const initialState: ComparisonInsightState = {
isLoading: true,
groupRows: true,
selectedDimensions: [],
mode: "impact",
mode: "outlier",
};

export const comparisonMetricsSlice = createSlice({
Expand Down

0 comments on commit 82898b4

Please sign in to comment.