fixing resize event bug

empress · Dec 11, 2018 · 87f4c90 · 87f4c90
1 parent b88769e
commit 87f4c90
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/app/components/floating-header.js b/app/components/floating-header.js
@@ -30,19 +30,30 @@ export default Component.extend({
     set(this, 'scrollEvent', scrollEvent);
     window.addEventListener('scroll', scrollEvent, {passive: true});
 
-    window.addEventListener('resize', () => {
+    let resizeEvent = () => {
       set(this, 'lastWindowHeight', window.innerHeight);
       set(this, 'lastDocumentHeight', $(document).height());
       this.requestTick();
-    }, false);
+    };
+
+    set(this, 'resizeEvent', resizeEvent);
+
+    window.addEventListener('resize', resizeEvent, false);
   },
 
   didDestroyElement() {
-    let scrollEvent = this.scrollEvent;
+    let scrollEvent = this.get('scrollEvent');
 
     if(scrollEvent) {
-      set(this, 'scrollEvent', null);
       window.removeEventListener('scroll', scrollEvent);
+      set(this, 'scrollEvent', null);
+    }
+
+    let resizeEvent = this.get('resizeEvent');
+
+    if(resizeEvent) {
+      window.removeEventListener('resize', resizeEvent);
+      set(this, 'resizeEvent', null);
     }
   },