support deployment to subdirectory #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
force-pushed
the
support-deployment-to-subdirectory
branch
from
c0ff9d9
to
9ab5bc9
Compare
mansona
force-pushed
the
support-deployment-to-subdirectory
branch
from
9ab5bc9
to
d95c1ca
Compare
mansona
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See empress/guidemaker#19 for context.
{{root-url}}template helper is a very simple one that prefixes a given URL with therootURLconfigured inconfig/environment.js.The template helper is provided by ember-root-url addon. Wouldn't be that complex to calculate in application controller but adding such a controller would be a breaking change cause consuming application might already have one. I don't see much value of adding the implementation of such a template helper directly to this addon.
This could still be a breaking change if consuming app already has a template helper with a different public API. But I don't think that's very likely.